Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

Alex Merry kde at randomguy3.me.uk
Sat Feb 1 11:45:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48742
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Feb. 1, 2014, 7:40 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115251/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2014, 7:40 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Add better runtime detection for X11 usage in KStartupInfo
> 
> Compile time checks for X11 is no longer sufficient. This adds a
> runtime check to all the code paths which look dangerous if executed
> on a non-X11 platform.
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.cpp 61e869b071efd24f07e041c7d035e387ee4d875c 
> 
> Diff: https://git.reviewboard.kde.org/r/115251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140201/e7b2cd41/attachment.html>


More information about the Kde-frameworks-devel mailing list