Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

Sat Feb 1 07:40:07 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
-----------------------------------------------------------

(Updated Feb. 1, 2014, 8:40 a.m.)

Review request for KDE Frameworks.

Changes
-------

removed the not-needed #if HAVE_X11

Repository: kwindowsystem

Description
-------

Add better runtime detection for X11 usage in KStartupInfo

Compile time checks for X11 is no longer sufficient. This adds a
runtime check to all the code paths which look dangerous if executed
on a non-X11 platform.

Diffs (updated)
-----

  src/kstartupinfo.cpp 61e869b071efd24f07e041c7d035e387ee4d875c 

Diff: https://git.reviewboard.kde.org/r/115251/diff/

Testing
-------

Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140201/040e9892/attachment.html>