Change in kio[master]: Add ark's "Extract Here" option to the context menu even whe...

Arjun AK (Code Review) noreply at kde.org
Thu Dec 18 18:18:02 UTC 2014


Arjun AK has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/250

Change subject: Add ark's "Extract Here" option to the context menu even when files are of different types
......................................................................

Add ark's "Extract Here" option to the context menu even when files are of different types

Currently "Extract Here" option is not added to the context menu
if the selected files are of different mimetypes. This means that
if the user has to extract multiple files of different types,
he will have to right click on each and every one of them instead of
being able to do it in a single go. This commit checks whether the mimetypes
of all the selected files are supported by ark and if so adds the "Extract Here"
option.

Change-Id: Ie9893953b885a492c1cab87deb8fff1c0fae2811
---
M src/widgets/kfileitemactions.cpp
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/kio refs/changes/50/250/1

diff --git a/src/widgets/kfileitemactions.cpp b/src/widgets/kfileitemactions.cpp
index 0cfeb3f..ecc53da 100644
--- a/src/widgets/kfileitemactions.cpp
+++ b/src/widgets/kfileitemactions.cpp
@@ -375,6 +375,12 @@
                     }
                 }
             }
+            // If all the files are archives, add ark's "Extract here" option
+            if ((*it2)->name() == "ark_servicemenu" && commonMimeType.isEmpty()) {
+               ok = std::all_of(items.constBegin(),
+                                items.constEnd(),
+                                [&types](const KFileItem &i){ return types.contains(i.mimetype()); });
+            }
 
             if (ok) {
                 const QString priority = cfg.readEntry("X-KDE-Priority");

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/250
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9893953b885a492c1cab87deb8fff1c0fae2811
Gerrit-PatchSet: 1
Gerrit-Project: kio
Gerrit-Branch: master
Gerrit-Owner: Arjun AK <arjunak234 at gmail.com>


More information about the Kde-frameworks-devel mailing list