Review Request 120388: Do not sync if wallet file does not exist

Arjun AK arjunak234 at gmail.com
Thu Dec 11 02:16:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 2:16 a.m.)


Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin Rusu.


Changes
-------

added people to review.


Repository: kwallet


Description
-------

1. Create a new wallet "foo"
2. immediately remove the 'kwalletd5' directory
3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which will create "foo.kwl")

Kwalletmanager still lists the wallet and new data can be added to the wallet, but this data will be lost once the wallet is closed since the salt has been deleted and therefore the wallet cannot be opened again.


Diffs
-----

  src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 

Diff: https://git.reviewboard.kde.org/r/120388/diff/


Testing
-------


Thanks,

Arjun AK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141211/e9f0e3a2/attachment.html>


More information about the Kde-frameworks-devel mailing list