Review Request 120388: Do not sync if wallet file does not exist

Aleix Pol Gonzalez aleixpol at kde.org
Thu Dec 11 02:15:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/#review71775
-----------------------------------------------------------


+1

Makes sense to me, still I'd like somebody more proficient in this project to review the change.

- Aleix Pol Gonzalez


On Sept. 27, 2014, 11:59 a.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120388/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 11:59 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> 1. Create a new wallet "foo"
> 2. immediately remove the 'kwalletd5' directory
> 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which will create "foo.kwl")
> 
> Kwalletmanager still lists the wallet and new data can be added to the wallet, but this data will be lost once the wallet is closed since the salt has been deleted and therefore the wallet cannot be opened again.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
> 
> Diff: https://git.reviewboard.kde.org/r/120388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141211/a046f21e/attachment.html>


More information about the Kde-frameworks-devel mailing list