Review Request 121299: Add NET::OSD window type

Kai Uwe Broulik kde at privat.broulik.de
Mon Dec 1 18:49:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121299/
-----------------------------------------------------------

(Updated Dez. 1, 2014, 6:49 nachm.)


Review request for KDE Frameworks, kwin and Martin Gräßlin.


Changes
-------

Rename to OnScreenDisplay / on_screen_display and fallback to notification type


Repository: kwindowsystem


Description
-------

This adds a NET::OSD window type for the OSD (eg. volume feedback) so it can be placed even ontop of active fullscreen windows in contrast to the Notifications.

Not sure whether a kde netwm thing is required or we could just use some other method in KWin to decide placement.

Also dunno what impact on ABI this has, I tried to only add enum values at the end.


Diffs (updated)
-----

  autotests/netwininfotestclient.cpp 16ba4b3 
  src/netwm.cpp 1ccba32 
  src/netwm_def.h 0352f33 

Diff: https://git.reviewboard.kde.org/r/121299/diff/


Testing
-------

In conjunction with Review 121300 these are now ontop of fullscreen windows.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/cb1ab84e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list