Review Request 121299: Add NET::OSD window type
Martin Gräßlin
mgraesslin at kde.org
Mon Dec 1 08:18:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121299/#review71144
-----------------------------------------------------------
I don't like the usage of a TLA. Could we make it OnScreenDisplay?
- Martin Gräßlin
On Nov. 30, 2014, 11:16 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121299/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2014, 11:16 p.m.)
>
>
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> This adds a NET::OSD window type for the OSD (eg. volume feedback) so it can be placed even ontop of active fullscreen windows in contrast to the Notifications.
>
> Not sure whether a kde netwm thing is required or we could just use some other method in KWin to decide placement.
>
> Also dunno what impact on ABI this has, I tried to only add enum values at the end.
>
>
> Diffs
> -----
>
> autotests/netwininfotestclient.cpp 16ba4b3
> src/netwm.cpp 1ccba32
> src/netwm_def.h 0352f33
>
> Diff: https://git.reviewboard.kde.org/r/121299/diff/
>
>
> Testing
> -------
>
> In conjunction with Review 121300 these are now ontop of fullscreen windows.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/85955834/attachment.html>
More information about the Kde-frameworks-devel
mailing list