Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65255
-----------------------------------------------------------



kde-modules/KDEInstallDirs.cmake
<https://git.reviewboard.kde.org/r/119901/#comment45602>

    I'd prefix the variable with KDE_.
    
    We are in KDEInstallDirs.cmake after all.
    
    Also make it explicit that it's OFF by default.



kde-modules/KDEInstallDirs.cmake
<https://git.reviewboard.kde.org/r/119901/#comment45603>

    Indent inside the if() and else()



kde-modules/KDEInstallDirs.cmake
<https://git.reviewboard.kde.org/r/119901/#comment45601>

    endif()



modules/ECMGeneratePriFile.cmake
<https://git.reviewboard.kde.org/r/119901/#comment45604>

    This variable is in KDEInstallDirs. It's a weird dependency to have...



modules/ECMGeneratePriFile.cmake
<https://git.reviewboard.kde.org/r/119901/#comment45599>

    endif()
    http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands



modules/ECMQueryQmake.cmake
<https://git.reviewboard.kde.org/r/119901/#comment45600>

    end*()
    
    http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands


- Aleix Pol Gonzalez


On Aug. 25, 2014, 6 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 6 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in ECM.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> -------
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140825/548c4c7a/attachment.html>