Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65242
-----------------------------------------------------------

Ship it!


LOL just when the naming started to make sense, you added mkspecs to it :-)

I can't come up with something better than ECM_INSTALL_QT_STUFF_IN_QT_DIR, so I'll stop nitpicking on naming....
Anyhow, distros will set it so plugins get installed there, and devs using qmake will be happy that mkspecs are following along.

- David Faure


On Aug. 25, 2014, 6 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 6 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in ECM.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> -------
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140825/3fc7dd1d/attachment.html>