Review Request 119846: qtcontrols port for checkbox and radiobutton

[David Edmundson]

> On Aug. 24, 2014, 9:53 a.m., Kai Uwe Broulik wrote:
> > With the port the checkbox no longer scales with dpi. The PM checkbox in battery monitor has become quite small here now.

the width/height looks like it has changed, it used to be

width: theme.mSize(theme.defaultFont).height + margins.left

now it's units.gridUnit

I didn't catch that before.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119846/#review65111
-----------------------------------------------------------


On Aug. 20, 2014, 6:51 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119846/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 6:51 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports checkbox and radiobuttons (and switch that at least on desktop formfactor is just an alias for checkboxes) to qtcontrols and adds the corresponding styles
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/CheckBox.qml 5e98d11 
>   src/declarativeimports/plasmacomponents/qml/RadioButton.qml 00a1bbf 
>   src/declarativeimports/plasmacomponents/qml/Switch.qml d0608f9 
>   src/declarativeimports/plasmacomponents/qml/ToolBar.qml 75ed0c0 
>   src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml PRE-CREATION 
>   src/desktoptheme/breeze/widgets/actionbutton.svgz 25aacc8 
> 
> Diff: https://git.reviewboard.kde.org/r/119846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140824/efc1016c/attachment-0001.html>