<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119846/">https://git.reviewboard.kde.org/r/119846/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 24th, 2014, 9:53 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With the port the checkbox no longer scales with dpi. The PM checkbox in battery monitor has become quite small here now.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the width/height looks like it has changed, it used to be</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">width: theme.mSize(theme.defaultFont).height + margins.left</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">now it's units.gridUnit</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't catch that before.</p></pre>
<br />
<p>- David</p>
<br />
<p>On August 20th, 2014, 6:51 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2014, 6:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this ports checkbox and radiobuttons (and switch that at least on desktop formfactor is just an alias for checkboxes) to qtcontrols and adds the corresponding styles</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qml/CheckBox.qml <span style="color: grey">(5e98d11)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/RadioButton.qml <span style="color: grey">(00a1bbf)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/Switch.qml <span style="color: grey">(d0608f9)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/ToolBar.qml <span style="color: grey">(75ed0c0)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze/widgets/actionbutton.svgz <span style="color: grey">(25aacc8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>