Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

David Faure faure at kde.org
Sun Aug 17 21:38:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119809/
-----------------------------------------------------------

(Updated Aug. 17, 2014, 9:38 p.m.)


Review request for KDE Frameworks and Eike Hein.


Repository: kio


Description
-------

This was within libkonq as KonqMultiRestoreJob, public API KonqOperations::restoreTrashedItems().

REVIEW: 119809


Diffs (updated)
-----

  src/core/restorejob.h PRE-CREATION 
  src/core/restorejob.cpp PRE-CREATION 
  autotests/fileundomanagertest.h 112657a1fcfea1e588e5fa53a1bbfccfe7a5de3d 
  autotests/fileundomanagertest.cpp c1f253b4e41bff6d96baa9017fe8d6c70386efb8 
  src/core/CMakeLists.txt 1e9ab98d2c0c27a696baab0bb8375c8cf81a3632 

Diff: https://git.reviewboard.kde.org/r/119809/diff/


Testing
-------

Added unittest; passes.

It reminded me that this operation wasn't undoable yet, though.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140817/8543f8b4/attachment.html>


More information about the Kde-frameworks-devel mailing list