Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

[David Faure]

> On Aug. 17, 2014, 6:07 p.m., Emmanuel Pescosta wrote:
> > src/core/restorejob.cpp, line 36
> > <https://git.reviewboard.kde.org/r/119809/diff/2/?file=305769#file305769line36>
> >
> >     constBegin() because m_urlsIterator is a const iterator

I compile with -DQT_STRICT_ITERATORS so the compiler tells me when I mix up the iterator types.

In fact urls is const, so this was a const iterator. But I should probably use m_urls rather than urls, and then indeed I need constBegin().


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119809/#review64687
-----------------------------------------------------------


On Aug. 17, 2014, 9:01 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119809/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2014, 9:01 a.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This was within libkonq as KonqMultiRestoreJob, public API KonqOperations::restoreTrashedItems().
> 
> REVIEW: 119809
> 
> 
> Diffs
> -----
> 
>   autotests/fileundomanagertest.h 112657a1fcfea1e588e5fa53a1bbfccfe7a5de3d 
>   autotests/fileundomanagertest.cpp c1f253b4e41bff6d96baa9017fe8d6c70386efb8 
>   src/core/CMakeLists.txt 1e9ab98d2c0c27a696baab0bb8375c8cf81a3632 
>   src/core/restorejob.h PRE-CREATION 
>   src/core/restorejob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119809/diff/
> 
> 
> Testing
> -------
> 
> Added unittest; passes.
> 
> It reminded me that this operation wasn't undoable yet, though.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140817/68915709/attachment.html>