Review Request 119767: Add Hamlet and Haskell quasiquotation

Dominik Haumann dhaumann at kde.org
Fri Aug 15 12:21:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119767/#review64598
-----------------------------------------------------------



src/syntax/data/haskell.xml
<https://git.reviewboard.kde.org/r/119767/#comment45144>

    This question persists:
    
    The rule 
    <DetectChar attribute="Normal" context="List or QuasiQuote" char="["/>
    from line 357 is included in this context.
    
    Matching '[' will switch to "List or QuasiQuote".
    Since the rule above is in this context again, finding '[' will again switch into this context, such that the contexts add up.
    
    That is what I meant before when asking "Do you ever #pop back to the context "code"?" :-)
    
    Would it also be possible to use fallthrough and fallthroughContext like this:
    <context attribute="Normal" lineEndContext="#stay" name="List or QuasiQuote" fallthrough="true" fallthroughContext="#pop">
    and then remove the line 360?
    <IncludeRules context="code" />


- Dominik Haumann


On Aug. 14, 2014, 8:39 p.m., Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119767/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 8:39 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> This request request mostly contains syntax highlighting for Hamlet
> files. Hamlet is a Haskell based Template language for creating
> HTML documents. As Hamlet can be embedded into an ordinary Haskell
> file with quasi quotation, this also implements QuasiQuotation support
> for Haskell files.
> 
> 
> Diffs
> -----
> 
>   src/syntax/data/hamlet.xml PRE-CREATION 
>   src/syntax/data/haskell.xml 104e43ddafb2e7ca5ccc84fcf8344267e3148e05 
> 
> Diff: https://git.reviewboard.kde.org/r/119767/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian Holst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140815/8c492b22/attachment.html>


More information about the Kde-frameworks-devel mailing list