Review Request 119773: Launch scripts in autostart-directories

[Martin Yrjölä]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119773/
-----------------------------------------------------------

Review request for KDE Frameworks.


Bugs: 335878 and 338242
    https://bugs.kde.org/show_bug.cgi?id=335878
    https://bugs.kde.org/show_bug.cgi?id=338242


Repository: kinit


Description
-------

This fixes execution of scripts other than ".desktop"-files in the ~/.config/autostart directory when starting a session. This functionality was removed in https://git.reviewboard.kde.org/r/118977/ because of https://bugs.kde.org/show_bug.cgi?id=335878.

Things that still have to be discussed:
* Is kinit the right place for this functionality? I think it makes sense because all other autostart functionality is there.
* Is kioclient5 the correct way to start the scripts?
* Which kind of files in autostart-directories gets executed?
 * I chose a simple *.sh regex for testing purposes.
 * In KSMServer and KDE4 only obvious backup files (*.bak, *~, %*% etc.) were excluded.


Diffs
-----

  src/klauncher/autostart.cpp 0706c735c3caf1c010d9968337456bfc5a0805c1 

Diff: https://git.reviewboard.kde.org/r/119773/diff/


Testing
-------

Works for scripts that exit and those that run the whole session. Now the only limitation is the *.sh wildcard.


Thanks,

Martin Yrjölä

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140813/8c60de7a/attachment.html>