Review Request 119714: Fix the build on Windows using MSVC 2013
Milian Wolff
mail at milianw.de
Mon Aug 11 15:23:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119714/#review64270
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On Aug. 11, 2014, 1:24 p.m., Cristian Oneț wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119714/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 1:24 p.m.)
>
>
> Review request for KDE Frameworks, Christoph Cullmann and Joseph Wenninger.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> The compiler was complaining about ambiguous method resolution using
> QAbstractItemModel::createIndex (because of the last parameter) so just
> remove it since QAbstractItemModel::createIndex has a default value
> for the last parameter in one of the overloads which is just what it's
> needed.
>
>
> Diffs
> -----
>
> src/completion/katekeywordcompletion.cpp e30a64d7de3be0f6470303024b0fd0fc034a12dd
>
> Diff: https://git.reviewboard.kde.org/r/119714/diff/
>
>
> Testing
> -------
>
> Built and run kate.
>
>
> Thanks,
>
> Cristian Oneț
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140811/1b79cd84/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list