Review Request 119714: Fix the build on Windows using MSVC 2013

[Joseph Wenninger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119714/#review64262
-----------------------------------------------------------

Ship it!


This should be save, default paramater is 0 anyways and internally in cute, the result is the same. It should not make a difference which overload is used.


 inline QModelIndex(int arow, int acolumn, void *ptr, const QAbstractItemModel *amodel)
        : r(arow), c(acolumn), i(reinterpret_cast<quintptr>(ptr)), m(amodel) {}
    Q_DECL_CONSTEXPR inline QModelIndex(int arow, int acolumn, quintptr id, const QAbstractItemModel *amode$
        : r(arow), c(acolumn), i(id), m(amodel) {}

- Joseph Wenninger


On Aug. 11, 2014, 1:24 nachm., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119714/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 1:24 nachm.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Joseph Wenninger.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> The compiler was complaining about ambiguous method resolution using
> QAbstractItemModel::createIndex (because of the last parameter) so just
> remove it since QAbstractItemModel::createIndex has a default value
> for the last parameter in one of the overloads which is just what it's
> needed.
> 
> 
> Diffs
> -----
> 
>   src/completion/katekeywordcompletion.cpp e30a64d7de3be0f6470303024b0fd0fc034a12dd 
> 
> Diff: https://git.reviewboard.kde.org/r/119714/diff/
> 
> 
> Testing
> -------
> 
> Built and run kate.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140811/e69dee6e/attachment-0001.html>