Review Request 119590: Disable the DDS and JPEG-2000 plugins when Qt version is 5.3 or later

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119590/#review63719
-----------------------------------------------------------

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Aug. 3, 2014, 7:57 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119590/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 7:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> QtImageFormats 5.3 comes with DDS and JPEG-2000 plugins that support
> more options and are generally better than our plugins. The only
> advantage our plugins offer is that the Qt DDS plugin does not work on
> sequential devices, while ours does. This is outweighed by other
> improvements, though, such as supporting more variants.
> 
> 
> (NB: I opted for disabling rather than removing because we want distros to push new KF5 versions back to stable distro versions, but they are probably not going to do the same with Qt 5.2 -> 5.3.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9aa14b44b6d5ccb484dc2ef58cc8d23cb392f1c0 
>   src/imageformats/CMakeLists.txt af169c1be308afae92992751d4cb655ef9b30a2f 
>   src/imageformats/dds-qt.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119590/diff/
> 
> 
> Testing
> -------
> 
> Built with Qt 5.3.1 - the JPEG-2000 and DDS plugins are not built, and the JPEG-2000 tests are not built or run.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140803/03dc07da/attachment.html>