<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119590/">https://git.reviewboard.kde.org/r/119590/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes sense to me.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On August 3rd, 2014, 7:57 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2014, 7:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QtImageFormats 5.3 comes with DDS and JPEG-2000 plugins that support<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
more options and are generally better than our plugins. The only<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
advantage our plugins offer is that the Qt DDS plugin does not work on<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
sequential devices, while ours does. This is outweighed by other<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
improvements, though, such as supporting more variants.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(NB: I opted for disabling rather than removing because we want distros to push new KF5 versions back to stable distro versions, but they are probably not going to do the same with Qt 5.2 -> 5.3.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built with Qt 5.3.1 - the JPEG-2000 and DDS plugins are not built, and the JPEG-2000 tests are not built or run.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9aa14b44b6d5ccb484dc2ef58cc8d23cb392f1c0)</span></li>
<li>src/imageformats/CMakeLists.txt <span style="color: grey">(af169c1be308afae92992751d4cb655ef9b30a2f)</span></li>
<li>src/imageformats/dds-qt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119590/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>