plasma-framework in kdereview

[Kevin Ottens]

Hello,

On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote:
> El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure:
> > since it was done earlier this week, better announce it formally, so
> > everybody can actually do the -review part ;)
> 
> Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken as the
> rest of frameworks ;-))

Thanks for looking into it.

I checked with Burkhard Lück too and he said it was fine on the doc side as 
well.
We just ended a clean up pass with Aurélien to make sure it was compliant with 
all the active policies, so it's now OK on our side as well.

As far as I'm concerned it's ready to move in frameworks now.

> I'll be fixed once Aurelien does the patch for all frameworks defining the
> cmake variable for the domain.
> 
> There's one thing that someone needs to think about and is this two strings
> in the qml files
> 
> QueryDialog.qml:52:    property string acceptButtonText: i18n("Ok")
> QueryDialog.qml:53:    property string rejectButtonText: i18n("Cancel")
> 
> That either need to load the catalog manually (the cmake define won't help
> here) or they need to specify the domain or they need to be killed and use
> som kguistdthing that provides those translations.

OK, thanks.

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140426/f2c42d61/attachment.sig>