Review Request 117583: Remove use of ecm_dbus_add_activation_service()

Commit Hook null at kde.org
Fri Apr 25 09:30:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117583/#review56492
-----------------------------------------------------------


This review has been submitted with commit 1ee89d48fe8338b21df3b26c673b8f6da5df7d1d by Alex Merry to branch master.

- Commit Hook


On April 16, 2014, 10:25 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117583/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 10:25 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Remove use of ecm_dbus_add_activation_service()
> 
> There is no point using an obscure macro that can be replaced with two
> straightforward CMake commands.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/CMakeLists.txt d9fb4b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117583/diff/
> 
> 
> Testing
> -------
> 
> Configured, built, installed, visually inspected $PREFIX/share/dbus-1/services/org.kde.kwalletd5.service.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140425/332d5051/attachment.html>


More information about the Kde-frameworks-devel mailing list