Review Request 117583: Remove use of ecm_dbus_add_activation_service()

Kevin Ottens ervin at kde.org
Thu Apr 24 22:14:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117583/#review56426
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On April 16, 2014, 10:25 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117583/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 10:25 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Remove use of ecm_dbus_add_activation_service()
> 
> There is no point using an obscure macro that can be replaced with two
> straightforward CMake commands.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/CMakeLists.txt d9fb4b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117583/diff/
> 
> 
> Testing
> -------
> 
> Configured, built, installed, visually inspected $PREFIX/share/dbus-1/services/org.kde.kwalletd5.service.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140424/3b3c004b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list