Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

Martin Gräßlin mgraesslin at kde.org
Fri Apr 25 07:02:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117731/
-----------------------------------------------------------

(Updated April 25, 2014, 7:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Thomas Lübking.


Repository: kwindowsystem


Description
-------

Improve KStartupInfo::Private::remove_startup_info_internal

Uses iterators to check whether startups, silent_startups or
unintended_startups contains the id and erases the element.

Method is renamed to removeAllStartupInfoInternal to point out the
difference to the method which just removes from startups.


Diffs
-----

  src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb 

Diff: https://git.reviewboard.kde.org/r/117731/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140425/330229bf/attachment.html>


More information about the Kde-frameworks-devel mailing list