Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117731/#review56468
-----------------------------------------------------------


This review has been submitted with commit 3ebc08046491d4df7c93928676b9b1c9cdd090d9 by Martin Gräßlin to branch master.

- Commit Hook


On April 24, 2014, 5:46 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117731/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 5:46 a.m.)
> 
> 
> Review request for KDE Frameworks and Thomas Lübking.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Improve KStartupInfo::Private::remove_startup_info_internal
> 
> Uses iterators to check whether startups, silent_startups or
> unintended_startups contains the id and erases the element.
> 
> Method is renamed to removeAllStartupInfoInternal to point out the
> difference to the method which just removes from startups.
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb 
> 
> Diff: https://git.reviewboard.kde.org/r/117731/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140425/e47f8899/attachment-0001.html>