Review Request 117304: Remove clipboard data re-fetching line and its comment

[Alex Merry]

> On April 1, 2014, 4:28 p.m., David Faure wrote:
> > How can you know that it wasn't true? The timer was inside Qt itself. This is about dropping non-URI data onto a file manager and getting the popup "how do you want to name the resulting file (to save this data)", and by the time you answer the question, the data had been deleted by Qt, so you couldn't save it. I'm not confident about this being removed without at least testing it in KDE4.

The execution appeared to go: get the data from QClipboard, pass it into a function (direct call), which passes it into another function (another direct call), which then re-fetches the data because it reckons the original has been deleted by a QTimer.  But we never went back to the event loop in the meantime, so nothing has changed.  There also didn't appear to be any QClipboard calls in the meantime that would cause the value returned by QApplication::clipboard()->data() to change.

Am I misreading the code?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117304/#review54803
-----------------------------------------------------------


On April 1, 2014, 4:01 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117304/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 4:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Remove clipboard data re-fetching line and its comment
> 
> The comment does not appear to be true.  What is more, I cannot see when
> it was ever true, including in commit 99209e91 where it was introduced.
> 
> 
> David: can you shed any light on this?
> 
> 
> Diffs
> -----
> 
>   src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 
> 
> Diff: https://git.reviewboard.kde.org/r/117304/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140401/0b9ebe44/attachment-0001.html>