<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117304/">https://git.reviewboard.kde.org/r/117304/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 1st, 2014, 4:28 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How can you know that it wasn't true? The timer was inside Qt itself. This is about dropping non-URI data onto a file manager and getting the popup "how do you want to name the resulting file (to save this data)", and by the time you answer the question, the data had been deleted by Qt, so you couldn't save it. I'm not confident about this being removed without at least testing it in KDE4.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The execution appeared to go: get the data from QClipboard, pass it into a function (direct call), which passes it into another function (another direct call), which then re-fetches the data because it reckons the original has been deleted by a QTimer. But we never went back to the event loop in the meantime, so nothing has changed. There also didn't appear to be any QClipboard calls in the meantime that would cause the value returned by QApplication::clipboard()->data() to change.
Am I misreading the code?</pre>
<br />
<p>- Alex</p>
<br />
<p>On April 1st, 2014, 4:01 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated April 1, 2014, 4:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove clipboard data re-fetching line and its comment
The comment does not appear to be true. What is more, I cannot see when
it was ever true, including in commit 99209e91 where it was introduced.
David: can you shed any light on this?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/paste.cpp <span style="color: grey">(1d1cafca2f494e44f9ba7bd279cefd7df813b9c0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117304/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>