Review Request 112874: Allow disabling of QCA plugins during build.

[Ivan Romanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112874/#review40973
-----------------------------------------------------------


Proposal #3 is a good way. Need some improvements. 
First. By default -DBUILD_PLUGINS must be 'all' that means build all possible plugins. The same behaviour like now. 
Second. If -DBUILD_PLUGINS is not 'all' and the plugin in the list can't be compiled cmake must be failed with an error message.
Third. Also (not required) please add description of -DBUILD_PLUGINS in INSTALL instructions.

- Ivan Romanov


On Sept. 28, 2013, 7:15 p.m., Uwe L. Korn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112874/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 7:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Romanov.
> 
> 
> Description
> -------
> 
> Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo.
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt eed741e 
>   plugins/qca-botan/CMakeLists.txt 1b9607c 
>   plugins/qca-cyrus-sasl/CMakeLists.txt b36cbcf 
>   plugins/qca-gcrypt/CMakeLists.txt f5c73bd 
>   plugins/qca-gnupg/CMakeLists.txt 7f46abf 
>   plugins/qca-nss/CMakeLists.txt 805567d 
>   plugins/qca-ossl/CMakeLists.txt 6b5c69c 
>   plugins/qca-pkcs11/CMakeLists.txt b220926 
>   plugins/qca-wincrypto/CMakeLists.txt c0ab378 
> 
> Diff: http://git.reviewboard.kde.org/r/112874/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed and used on Gentoo (with Qt5).
> 
> 
> Thanks,
> 
> Uwe L. Korn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130929/a45e2692/attachment.html>