<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112874/">http://git.reviewboard.kde.org/r/112874/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Proposal #3 is a good way. Need some improvements.
First. By default -DBUILD_PLUGINS must be 'all' that means build all possible plugins. The same behaviour like now.
Second. If -DBUILD_PLUGINS is not 'all' and the plugin in the list can't be compiled cmake must be failed with an error message.
Third. Also (not required) please add description of -DBUILD_PLUGINS in INSTALL instructions.</pre>
<br />
<p>- Ivan</p>
<br />
<p>On September 28th, 2013, 7:15 p.m. YEKT, Uwe L. Korn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Ivan Romanov.</div>
<div>By Uwe L. Korn.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2013, 7:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, installed and used on Gentoo (with Qt5).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/CMakeLists.txt <span style="color: grey">(eed741e)</span></li>
<li>plugins/qca-botan/CMakeLists.txt <span style="color: grey">(1b9607c)</span></li>
<li>plugins/qca-cyrus-sasl/CMakeLists.txt <span style="color: grey">(b36cbcf)</span></li>
<li>plugins/qca-gcrypt/CMakeLists.txt <span style="color: grey">(f5c73bd)</span></li>
<li>plugins/qca-gnupg/CMakeLists.txt <span style="color: grey">(7f46abf)</span></li>
<li>plugins/qca-nss/CMakeLists.txt <span style="color: grey">(805567d)</span></li>
<li>plugins/qca-ossl/CMakeLists.txt <span style="color: grey">(6b5c69c)</span></li>
<li>plugins/qca-pkcs11/CMakeLists.txt <span style="color: grey">(b220926)</span></li>
<li>plugins/qca-wincrypto/CMakeLists.txt <span style="color: grey">(c0ab378)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112874/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>