Review Request 112942: Move KDNSSD to tier2

[Aleix Pol Gonzalez]

> On Sept. 25, 2013, 6:45 p.m., Martin Klapetek wrote:
> > Isn't part of the "done" to have unit tests?

I'm not a DNSSD developer, I don't know what would apply as a useful test.

I agree that it's a bad thing for a framework not to be unit tested though, maybe we can create a tier for those modules without tests and call it "unmaintained".


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112942/#review40792
-----------------------------------------------------------


On Sept. 25, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112942/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 5:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Moves KDNSSD to tier2, fixes some missing dependencies.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eb1ea8c 
>   dnssd/CMakeLists.txt 15284e0 
>   dnssd/ConfigureChecks.cmake  
>   dnssd/KDNSSDConfig.cmake.in  
>   dnssd/Mainpage.dox  
>   dnssd/PACKAGERS  
>   dnssd/config-dnssd.h.cmake  
>   dnssd/src/CMakeLists.txt  
>   dnssd/src/avahi-domainbrowser.cpp  
>   dnssd/src/avahi-domainbrowser_p.h  
>   dnssd/src/avahi-publicservice.cpp  
>   dnssd/src/avahi-publicservice_p.h  
>   dnssd/src/avahi-remoteservice.cpp  
>   dnssd/src/avahi-remoteservice_p.h  
>   dnssd/src/avahi-servicebrowser.cpp  
>   dnssd/src/avahi-servicebrowser_p.h  
>   dnssd/src/avahi-servicetypebrowser.cpp  
>   dnssd/src/avahi-servicetypebrowser_p.h  
>   dnssd/src/avahi_entrygroup_interface.h  
>   dnssd/src/avahi_entrygroup_interface.cpp  
>   dnssd/src/avahi_server_interface.h  
>   dnssd/src/avahi_server_interface.cpp  
>   dnssd/src/avahi_serviceresolver_interface.h  
>   dnssd/src/avahi_serviceresolver_interface.cpp  
>   dnssd/src/domainbrowser.h  
>   dnssd/src/domainmodel.h  
>   dnssd/src/domainmodel.cpp  
>   dnssd/src/dummy-domainbrowser.cpp  
>   dnssd/src/dummy-publicservice.cpp  
>   dnssd/src/dummy-remoteservice.cpp  
>   dnssd/src/dummy-servicebrowser.cpp  
>   dnssd/src/dummy-servicetypebrowser.cpp  
>   dnssd/src/kcm_kdnssd.kcfg  
>   dnssd/src/mdnsd-domainbrowser.cpp  
>   dnssd/src/mdnsd-domainbrowser_p.h  
>   dnssd/src/mdnsd-publicservice.cpp  
>   dnssd/src/mdnsd-remoteservice.cpp  
>   dnssd/src/mdnsd-responder.h  
>   dnssd/src/mdnsd-responder.cpp  
>   dnssd/src/mdnsd-sdevent.h  
>   dnssd/src/mdnsd-servicebrowser.cpp  
>   dnssd/src/mdnsd-servicebrowser_p.h  
>   dnssd/src/mdnsd-servicetypebrowser.cpp  
>   dnssd/src/mdnsd-servicetypebrowser_p.h  
>   dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
>   dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
>   dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   dnssd/src/publicservice.h  
>   dnssd/src/remoteservice.h  
>   dnssd/src/servicebase.h  
>   dnssd/src/servicebase.cpp  
>   dnssd/src/servicebase_p.h  
>   dnssd/src/servicebrowser.h  
>   dnssd/src/servicemodel.h  
>   dnssd/src/servicemodel.cpp  
>   dnssd/src/servicetypebrowser.h  
>   dnssd/src/settings.kcfgc  
>   staging/kde4support/src/ConfigureChecks.cmake 21cac3f 
>   tier2/CMakeLists.txt 73175b3 
> 
> Diff: http://git.reviewboard.kde.org/r/112942/diff/
> 
> 
> Testing
> -------
> 
> Builds, no tests
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130925/a8e9f108/attachment.html>