<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112942/">http://git.reviewboard.kde.org/r/112942/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 25th, 2013, 6:45 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't part of the "done" to have unit tests?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not a DNSSD developer, I don't know what would apply as a useful test.
I agree that it's a bad thing for a framework not to be unit tested though, maybe we can create a tier for those modules without tests and call it "unmaintained".</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 25th, 2013, 5:35 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2013, 5:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves KDNSSD to tier2, fixes some missing dependencies.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, no tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(eb1ea8c)</span></li>
<li>dnssd/CMakeLists.txt <span style="color: grey">(15284e0)</span></li>
<li>dnssd/ConfigureChecks.cmake <span style="color: grey">()</span></li>
<li>dnssd/KDNSSDConfig.cmake.in <span style="color: grey">()</span></li>
<li>dnssd/Mainpage.dox <span style="color: grey">()</span></li>
<li>dnssd/PACKAGERS <span style="color: grey">()</span></li>
<li>dnssd/config-dnssd.h.cmake <span style="color: grey">()</span></li>
<li>dnssd/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-domainbrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-domainbrowser_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-publicservice.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-publicservice_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-remoteservice.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-remoteservice_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-servicebrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-servicebrowser_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-servicetypebrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi-servicetypebrowser_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi_entrygroup_interface.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi_entrygroup_interface.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi_server_interface.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi_server_interface.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/avahi_serviceresolver_interface.h <span style="color: grey">()</span></li>
<li>dnssd/src/avahi_serviceresolver_interface.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/domainbrowser.h <span style="color: grey">()</span></li>
<li>dnssd/src/domainmodel.h <span style="color: grey">()</span></li>
<li>dnssd/src/domainmodel.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/dummy-domainbrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/dummy-publicservice.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/dummy-remoteservice.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/dummy-servicebrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/dummy-servicetypebrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/kcm_kdnssd.kcfg <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-domainbrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-domainbrowser_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-publicservice.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-remoteservice.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-responder.h <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-responder.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-sdevent.h <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-servicebrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-servicebrowser_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-servicetypebrowser.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/mdnsd-servicetypebrowser_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml <span style="color: grey">()</span></li>
<li>dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml <span style="color: grey">()</span></li>
<li>dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml <span style="color: grey">()</span></li>
<li>dnssd/src/publicservice.h <span style="color: grey">()</span></li>
<li>dnssd/src/remoteservice.h <span style="color: grey">()</span></li>
<li>dnssd/src/servicebase.h <span style="color: grey">()</span></li>
<li>dnssd/src/servicebase.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/servicebase_p.h <span style="color: grey">()</span></li>
<li>dnssd/src/servicebrowser.h <span style="color: grey">()</span></li>
<li>dnssd/src/servicemodel.h <span style="color: grey">()</span></li>
<li>dnssd/src/servicemodel.cpp <span style="color: grey">()</span></li>
<li>dnssd/src/servicetypebrowser.h <span style="color: grey">()</span></li>
<li>dnssd/src/settings.kcfgc <span style="color: grey">()</span></li>
<li>staging/kde4support/src/ConfigureChecks.cmake <span style="color: grey">(21cac3f)</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(73175b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112942/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>