Review Request 112900: Prepare KDNSSD for moving

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 24 11:14:06 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112900/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 11:14 a.m.)


Review request for KDE Frameworks.


Changes
-------

Remove the build fix, didn't belong to the patch.


Description
-------

Prepares the module to be moved to its own tier.

There's a rather uncommon case with this module because there's a dependency against KConfig, but it only applies to when it's compiled with the mdnsd backend (only when there's no Avahi but mDns instead). I guess this makes it tier 2, but I'm not all that sure about that.


Diffs (updated)
-----

  dnssd/CMakeLists.txt a2dd8e6 
  dnssd/KDNSSDConfig.cmake.in PRE-CREATION 
  dnssd/src/CMakeLists.txt 47587af 
  dnssd/src/avahi-publicservice.cpp 119c5a8 
  dnssd/src/mdnsd-publicservice.cpp 2a775fa 
  dnssd/src/servicemodel.cpp 348db57 

Diff: http://git.reviewboard.kde.org/r/112900/diff/


Testing
-------

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/2c2599fe/attachment.html>


More information about the Kde-frameworks-devel mailing list