Review Request 112900: Prepare KDNSSD for moving

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112900/#review40644
-----------------------------------------------------------


Yes, looks like a tier 2 in that case. I wonder if that KConfig link could be spared though, it looks rather minimal somehow.


staging/kde4support/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112900/#comment29917>

    How is it related to the rest of the patch?


- Kevin Ottens


On Sept. 23, 2013, 5:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112900/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 5:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Prepares the module to be moved to its own tier.
> 
> There's a rather uncommon case with this module because there's a dependency against KConfig, but it only applies to when it's compiled with the mdnsd backend (only when there's no Avahi but mDns instead). I guess this makes it tier 2, but I'm not all that sure about that.
> 
> 
> Diffs
> -----
> 
>   dnssd/CMakeLists.txt a2dd8e6 
>   dnssd/KDNSSDConfig.cmake.in PRE-CREATION 
>   dnssd/src/CMakeLists.txt 47587af 
>   dnssd/src/avahi-publicservice.cpp 119c5a8 
>   dnssd/src/mdnsd-publicservice.cpp 2a775fa 
>   dnssd/src/servicemodel.cpp 348db57 
>   staging/kde4support/CMakeLists.txt 24ee457 
> 
> Diff: http://git.reviewboard.kde.org/r/112900/diff/
> 
> 
> Testing
> -------
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130924/a5157986/attachment-0001.html>