Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig
Commit Hook
null at kde.org
Mon Sep 23 15:51:28 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112598/#review40582
-----------------------------------------------------------
This review has been submitted with commit 3690c92db64315b3e016ec669e3e11e59218b536 by Martin Gräßlin to branch frameworks.
- Commit Hook
On Sept. 9, 2013, 6:51 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112598/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 6:51 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> The behavior to get a memory-only KConfig if file name is empty and the SimpleConfig open flag is used got lost by always setting the file name to the mainConfigName.
>
>
> Diffs
> -----
>
> tier1/kconfig/src/core/ksharedconfig.cpp 3b53e32
>
> Diff: http://git.reviewboard.kde.org/r/112598/diff/
>
>
> Testing
> -------
>
> a failing KWin unit test doesn't fail any more.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/1db3e1d5/attachment.html>
More information about the Kde-frameworks-devel
mailing list