Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

Kevin Ottens ervin at kde.org
Mon Sep 23 10:21:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112598/#review40512
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Sept. 9, 2013, 6:51 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112598/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 6:51 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> The behavior to get a memory-only KConfig if file name is empty and the SimpleConfig open flag is used got lost by always setting the file name to the mainConfigName.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/src/core/ksharedconfig.cpp 3b53e32 
> 
> Diff: http://git.reviewboard.kde.org/r/112598/diff/
> 
> 
> Testing
> -------
> 
> a failing KWin unit test doesn't fail any more.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/8df0bba9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list