Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112882/#review40532
-----------------------------------------------------------



staging/kcmutils/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112882/#comment29845>

    KCMUTILS?



staging/kcmutils/KCMUtilsConfig.cmake.in
<http://git.reviewboard.kde.org/r/112882/#comment29846>

    You should check on its dependencies, not just KCoreAddons. I'd expect something somewhat parallel to the target_link_libraries calls.



staging/kprintutils/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112882/#comment29844>

    KPRINTUTILS?



staging/kprintutils/KPrintUtilsConfig.cmake.in
<http://git.reviewboard.kde.org/r/112882/#comment29847>

    I surely has other dependencies.


- Kevin Ottens


On Sept. 22, 2013, 12:32 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112882/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2013, 12:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Split remaining KUtils into kcmutils and kprintutils and move them to staging
> 
> --
> 
> There's still a few things that need doing before it's ready for moving into a real tier. Those will come in a different commit/review.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4dff35d 
>   kutils/CMakeLists.txt 0cb281d 
>   kutils/Mainpage.dox  
>   kutils/TODO  
>   kutils/dummy.cpp 668f87b 
>   kutils/kcmodulecontainer.h  
>   kutils/kcmodulecontainer.cpp  
>   kutils/kcmoduleinfo.h  
>   kutils/kcmoduleinfo.cpp  
>   kutils/kcmoduleloader.h  
>   kutils/kcmoduleloader.cpp  
>   kutils/kcmoduleproxy.h  
>   kutils/kcmoduleproxy.cpp  
>   kutils/kcmoduleproxy_p.h  
>   kutils/kcmultidialog.h  
>   kutils/kcmultidialog.cpp  
>   kutils/kcmultidialog_p.h  
>   kutils/kdeglobals.kcfg  
>   kutils/kdeglobals.kcfgc  
>   kutils/kpluginselector.h  
>   kutils/kpluginselector.cpp  
>   kutils/kpluginselector_p.h  
>   kutils/kprintpreview.h  
>   kutils/kprintpreview.cpp  
>   kutils/ksettings/README.dox  
>   kutils/ksettings/TODO  
>   kutils/ksettings/componentsdialog.cpp  
>   kutils/ksettings/componentsdialog_p.h  
>   kutils/ksettings/dialog.h  
>   kutils/ksettings/dialog.cpp  
>   kutils/ksettings/dialog_p.h  
>   kutils/ksettings/dispatcher.h  
>   kutils/ksettings/dispatcher.cpp  
>   kutils/ksettings/dispatcher_p.h  
>   kutils/ksettings/pluginpage.h  
>   kutils/ksettings/pluginpage.cpp  
>   kutils/ksettingswidgetadaptor.h  
>   kutils/ksettingswidgetadaptor.cpp  
>   staging/CMakeLists.txt 5c52cbe 
>   staging/kcmutils/CMakeLists.txt PRE-CREATION 
>   staging/kcmutils/KCMUtilsConfig.cmake.in PRE-CREATION 
>   staging/kcmutils/src/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/CMakeLists.txt PRE-CREATION 
>   staging/kprintutils/KPrintUtilsConfig.cmake.in PRE-CREATION 
>   staging/kprintutils/src/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112882/diff/
> 
> 
> Testing
> -------
> 
> build + compiles
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/514c4ad7/attachment-0001.html>