<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112882/">http://git.reviewboard.kde.org/r/112882/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112882/diff/1/?file=191205#file191205line18" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcmutils/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ecm_setup_version</span><span class="p">(</span><span class="s">5</span> <span class="s">0</span> <span class="s">0</span> <span class="s">VARIABLE_PREFIX</span> <span class="s">KUTILS</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KCMUTILS?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112882/diff/1/?file=191206#file191206line3" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcmutils/KCMUtilsConfig.cmake.in</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">find_dependency(KCoreAddons "${PACKAGE_VERSION}")</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should check on its dependencies, not just KCoreAddons. I'd expect something somewhat parallel to the target_link_libraries calls.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112882/diff/1/?file=191208#file191208line19" style="color: black; font-weight: bold; text-decoration: underline;">staging/kprintutils/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ecm_setup_version</span><span class="p">(</span><span class="s">5</span> <span class="s">0</span> <span class="s">0</span> <span class="s">VARIABLE_PREFIX</span> <span class="s">KUTILS</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KPRINTUTILS?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112882/diff/1/?file=191209#file191209line3" style="color: black; font-weight: bold; text-decoration: underline;">staging/kprintutils/KPrintUtilsConfig.cmake.in</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">find_dependency(KCoreAddons "${PACKAGE_VERSION}")</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I surely has other dependencies.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On September 22nd, 2013, 12:32 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2013, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split remaining KUtils into kcmutils and kprintutils and move them to staging
--
There's still a few things that need doing before it's ready for moving into a real tier. Those will come in a different commit/review.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build + compiles
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4dff35d)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(0cb281d)</span></li>
<li>kutils/Mainpage.dox <span style="color: grey">()</span></li>
<li>kutils/TODO <span style="color: grey">()</span></li>
<li>kutils/dummy.cpp <span style="color: grey">(668f87b)</span></li>
<li>kutils/kcmodulecontainer.h <span style="color: grey">()</span></li>
<li>kutils/kcmodulecontainer.cpp <span style="color: grey">()</span></li>
<li>kutils/kcmoduleinfo.h <span style="color: grey">()</span></li>
<li>kutils/kcmoduleinfo.cpp <span style="color: grey">()</span></li>
<li>kutils/kcmoduleloader.h <span style="color: grey">()</span></li>
<li>kutils/kcmoduleloader.cpp <span style="color: grey">()</span></li>
<li>kutils/kcmoduleproxy.h <span style="color: grey">()</span></li>
<li>kutils/kcmoduleproxy.cpp <span style="color: grey">()</span></li>
<li>kutils/kcmoduleproxy_p.h <span style="color: grey">()</span></li>
<li>kutils/kcmultidialog.h <span style="color: grey">()</span></li>
<li>kutils/kcmultidialog.cpp <span style="color: grey">()</span></li>
<li>kutils/kcmultidialog_p.h <span style="color: grey">()</span></li>
<li>kutils/kdeglobals.kcfg <span style="color: grey">()</span></li>
<li>kutils/kdeglobals.kcfgc <span style="color: grey">()</span></li>
<li>kutils/kpluginselector.h <span style="color: grey">()</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">()</span></li>
<li>kutils/kpluginselector_p.h <span style="color: grey">()</span></li>
<li>kutils/kprintpreview.h <span style="color: grey">()</span></li>
<li>kutils/kprintpreview.cpp <span style="color: grey">()</span></li>
<li>kutils/ksettings/README.dox <span style="color: grey">()</span></li>
<li>kutils/ksettings/TODO <span style="color: grey">()</span></li>
<li>kutils/ksettings/componentsdialog.cpp <span style="color: grey">()</span></li>
<li>kutils/ksettings/componentsdialog_p.h <span style="color: grey">()</span></li>
<li>kutils/ksettings/dialog.h <span style="color: grey">()</span></li>
<li>kutils/ksettings/dialog.cpp <span style="color: grey">()</span></li>
<li>kutils/ksettings/dialog_p.h <span style="color: grey">()</span></li>
<li>kutils/ksettings/dispatcher.h <span style="color: grey">()</span></li>
<li>kutils/ksettings/dispatcher.cpp <span style="color: grey">()</span></li>
<li>kutils/ksettings/dispatcher_p.h <span style="color: grey">()</span></li>
<li>kutils/ksettings/pluginpage.h <span style="color: grey">()</span></li>
<li>kutils/ksettings/pluginpage.cpp <span style="color: grey">()</span></li>
<li>kutils/ksettingswidgetadaptor.h <span style="color: grey">()</span></li>
<li>kutils/ksettingswidgetadaptor.cpp <span style="color: grey">()</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(5c52cbe)</span></li>
<li>staging/kcmutils/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcmutils/KCMUtilsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcmutils/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kprintutils/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kprintutils/KPrintUtilsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kprintutils/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112882/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>