Review Request 112830: Start splitting KParts

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112830/#review40526
-----------------------------------------------------------



khtml/java/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112830/#comment29837>

    Does it really need the kio lib? Or it could use one of the KIOCore/Gui/Widgets splitted libs?



khtml/java/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112830/#comment29838>

    ditto.


- Kevin Ottens


On Sept. 19, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112830/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 6:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Started reorganizing KParts, everything stopped compiling, that fixes it too.
> 
> Make string to QStrign casts explicit.
> KParts was exporting the "kio" linking, don't do it anymore.
> 
> 
> Diffs
> -----
> 
>   interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
>   interfaces/terminal/example/CMakeLists.txt 57201fa 
>   kdewebkit/CMakeLists.txt cdc5835 
>   khtml/CMakeLists.txt bbaa4bb 
>   khtml/html/ksslkeygen.cpp a3118da 
>   khtml/html/ksslkeygen_p.h 95c1a71 
>   khtml/java/CMakeLists.txt a9e5abf 
>   khtml/java/tests/CMakeLists.txt 59bef3a 
>   khtml/kmultipart/CMakeLists.txt aa62156 
>   khtml/tests/CMakeLists.txt 99b3bdd 
>   kio/CMakeLists.txt aedded2 
>   kparts/CMakeLists.txt 6ab9391 
>   kparts/browserrun.h e758241 
>   kparts/tests/CMakeLists.txt 0e9b2b2 
>   kparts/tests/normalktm.cpp dcc3a5e 
>   kparts/tests/notepad.cpp b7c3778 
>   kparts/tests/openorsavequestion.cpp c080cfc 
>   kparts/tests/openorsavequestion_unittest.cpp 72285b1 
>   kparts/tests/parts.cpp ee198e3 
>   kparts/tests/parttest.h  
>   kparts/tests/parttest.cpp 828666f 
>   kparts/tests/partviewer.cpp eeeb63a 
>   kparts/tests/plugin_spellcheck.cpp 073144b 
>   kparts/tests/testmainwindow.cpp fd77af0 
>   kross/modules/CMakeLists.txt fa5cc10 
>   kross/ui/CMakeLists.txt 9e7806d 
>   kutils/CMakeLists.txt 0cb281d 
>   staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b 
> 
> Diff: http://git.reviewboard.kde.org/r/112830/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/60a84170/attachment.html>