<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112830/">http://git.reviewboard.kde.org/r/112830/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112830/diff/1/?file=190794#file190794line26" style="color: black; font-weight: bold; text-decoration: underline;">khtml/java/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kjavaappletviewer</span> <span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDE4_KPARTS_LIBS</span></span><span class="o"><span class="hl">}</span></span> <span class="o">${</span><span class="nv">KWindowSystem_LIBRARIES</span><span class="o">}</span> <span class="s">KInterProcessWindowing</span> <span class="s">KDE4Support</span> <span class="s">XmlGui</span> <span class="s">KI18n</span> <span class="s">KIconThemes</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kjavaappletviewer</span> <span class="s"><span class="hl">Qt5::Network</span></span><span class="hl"> </span><span class="s"><span class="hl">KParts</span></span><span class="hl"> </span><span class="s"><span class="hl">kio</span></span> <span class="o">${</span><span class="nv">KWindowSystem_LIBRARIES</span><span class="o">}</span> <span class="s">KInterProcessWindowing</span> <span class="s">KDE4Support</span> <span class="s">XmlGui</span> <span class="s">KI18n</span> <span class="s">KIconThemes</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does it really need the kio lib? Or it could use one of the KIOCore/Gui/Widgets splitted libs?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112830/diff/1/?file=190795#file190795line27" style="color: black; font-weight: bold; text-decoration: underline;">khtml/java/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">kio</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ditto.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On September 19th, 2013, 6:11 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2013, 6:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Started reorganizing KParts, everything stopped compiling, that fixes it too.
Make string to QStrign casts explicit.
KParts was exporting the "kio" linking, don't do it anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/kmediaplayer/CMakeLists.txt <span style="color: grey">(3d1797d)</span></li>
<li>interfaces/terminal/example/CMakeLists.txt <span style="color: grey">(57201fa)</span></li>
<li>kdewebkit/CMakeLists.txt <span style="color: grey">(cdc5835)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(bbaa4bb)</span></li>
<li>khtml/html/ksslkeygen.cpp <span style="color: grey">(a3118da)</span></li>
<li>khtml/html/ksslkeygen_p.h <span style="color: grey">(95c1a71)</span></li>
<li>khtml/java/CMakeLists.txt <span style="color: grey">(a9e5abf)</span></li>
<li>khtml/java/tests/CMakeLists.txt <span style="color: grey">(59bef3a)</span></li>
<li>khtml/kmultipart/CMakeLists.txt <span style="color: grey">(aa62156)</span></li>
<li>khtml/tests/CMakeLists.txt <span style="color: grey">(99b3bdd)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(aedded2)</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(6ab9391)</span></li>
<li>kparts/browserrun.h <span style="color: grey">(e758241)</span></li>
<li>kparts/tests/CMakeLists.txt <span style="color: grey">(0e9b2b2)</span></li>
<li>kparts/tests/normalktm.cpp <span style="color: grey">(dcc3a5e)</span></li>
<li>kparts/tests/notepad.cpp <span style="color: grey">(b7c3778)</span></li>
<li>kparts/tests/openorsavequestion.cpp <span style="color: grey">(c080cfc)</span></li>
<li>kparts/tests/openorsavequestion_unittest.cpp <span style="color: grey">(72285b1)</span></li>
<li>kparts/tests/parts.cpp <span style="color: grey">(ee198e3)</span></li>
<li>kparts/tests/parttest.h <span style="color: grey">()</span></li>
<li>kparts/tests/parttest.cpp <span style="color: grey">(828666f)</span></li>
<li>kparts/tests/partviewer.cpp <span style="color: grey">(eeeb63a)</span></li>
<li>kparts/tests/plugin_spellcheck.cpp <span style="color: grey">(073144b)</span></li>
<li>kparts/tests/testmainwindow.cpp <span style="color: grey">(fd77af0)</span></li>
<li>kross/modules/CMakeLists.txt <span style="color: grey">(fa5cc10)</span></li>
<li>kross/ui/CMakeLists.txt <span style="color: grey">(9e7806d)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(0cb281d)</span></li>
<li>staging/xmlgui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(372856b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112830/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>