Review Request 112757: kwindowsystem - remove unused dependencies

Kevin Ottens ervin at kde.org
Mon Sep 23 10:25:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112757/#review40513
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Sept. 16, 2013, 2:15 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112757/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Apart from a stray include, I did not find any reference to QtDBus or QtNetwork. Also, QtTest is already specified in autotests/, so no need to require it in the root.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/CMakeLists.txt 984db7fc814bb4c2342835f9b7034055f06f93ca 
>   tier1/kwindowsystem/autotests/CMakeLists.txt a1a7066f24aabb4e24b3920a462845e92a7ec5e4 
>   tier1/kwindowsystem/src/kwindowinfo_mac.cpp 1bf0876435a6ebd48db145635a49f89199de848f 
>   tier1/kwindowsystem/src/kwindowinfo_x11.cpp f382e9c0c580ec209bd75994fedd5f20584af5e2 
>   tier1/kwindowsystem/src/kwindowsystem_mac.cpp 6133a0bf3c4ca5d000cb3499f486e126d60c0873 
> 
> Diff: http://git.reviewboard.kde.org/r/112757/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass with QtDBus and QtNetwork not installed.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/00cb4967/attachment.html>


More information about the Kde-frameworks-devel mailing list