<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112757/">http://git.reviewboard.kde.org/r/112757/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Kevin</p>
<br />
<p>On September 16th, 2013, 2:15 p.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2013, 2:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from a stray include, I did not find any reference to QtDBus or QtNetwork. Also, QtTest is already specified in autotests/, so no need to require it in the root.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and tests pass with QtDBus and QtNetwork not installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwindowsystem/CMakeLists.txt <span style="color: grey">(984db7fc814bb4c2342835f9b7034055f06f93ca)</span></li>
<li>tier1/kwindowsystem/autotests/CMakeLists.txt <span style="color: grey">(a1a7066f24aabb4e24b3920a462845e92a7ec5e4)</span></li>
<li>tier1/kwindowsystem/src/kwindowinfo_mac.cpp <span style="color: grey">(1bf0876435a6ebd48db145635a49f89199de848f)</span></li>
<li>tier1/kwindowsystem/src/kwindowinfo_x11.cpp <span style="color: grey">(f382e9c0c580ec209bd75994fedd5f20584af5e2)</span></li>
<li>tier1/kwindowsystem/src/kwindowsystem_mac.cpp <span style="color: grey">(6133a0bf3c4ca5d000cb3499f486e126d60c0873)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112757/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>