Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
Kevin Ottens
ervin at kde.org
Mon Sep 23 10:07:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review40510
-----------------------------------------------------------
Tested the patch in my tree, works for caps lock too.
Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?
tier1/kguiaddons/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112443/#comment29830>
This dependency is unwanted in kguiaddons.
tier1/kguiaddons/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112443/#comment29831>
ditto.
tier1/kguiaddons/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112443/#comment29832>
ditto.
- Kevin Ottens
On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 6:37 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines.
>
>
> Diffs
> -----
>
> tier1/kguiaddons/CMakeLists.txt 3124c4d
> tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa
> tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29
> tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e
> tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41
>
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
>
>
> Testing
> -------
>
> used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/78740f65/attachment.html>
More information about the Kde-frameworks-devel
mailing list