Review Request 112758: Move KCompletion to tier2

David Faure faure at kde.org
Thu Sep 19 07:13:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112758/#review40320
-----------------------------------------------------------

Ship it!


Did you check that it passes the "definition of done" from the wiki?

- David Faure


On Sept. 16, 2013, 3:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112758/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 3:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Not much else.
> 
> 
> Diffs
> -----
> 
>   staging/CMakeLists.txt 7826b07 
>   staging/kcompletion/CMakeLists.txt  
>   staging/kcompletion/KCompletionConfig.cmake.in  
>   staging/kcompletion/autotests/CMakeLists.txt  
>   staging/kcompletion/autotests/kcombobox_unittest.cpp  
>   staging/kcompletion/autotests/kcompletioncoretest.h  
>   staging/kcompletion/autotests/kcompletioncoretest.cpp  
>   staging/kcompletion/autotests/klineedit_unittest.cpp  
>   staging/kcompletion/autotests/ksortablelisttest.cpp  
>   staging/kcompletion/src/CMakeLists.txt  
>   staging/kcompletion/src/kcombobox.h  
>   staging/kcompletion/src/kcombobox.cpp  
>   staging/kcompletion/src/kcompletion.h  
>   staging/kcompletion/src/kcompletion.cpp  
>   staging/kcompletion/src/kcompletion_p.h  
>   staging/kcompletion/src/kcompletionbase.cpp  
>   staging/kcompletion/src/kcompletionbox.h  
>   staging/kcompletion/src/kcompletionbox.cpp  
>   staging/kcompletion/src/khistorycombobox.h  
>   staging/kcompletion/src/khistorycombobox.cpp  
>   staging/kcompletion/src/klineedit.h  
>   staging/kcompletion/src/klineedit.cpp  
>   staging/kcompletion/src/klineedit_p.h  
>   staging/kcompletion/src/kpixmapprovider.h  
>   staging/kcompletion/src/kpixmapprovider.cpp  
>   staging/kcompletion/src/ksortablelist.h  
>   staging/kcompletion/src/kzoneallocator.cpp  
>   staging/kcompletion/src/kzoneallocator_p.h  
>   staging/kcompletion/tests/CMakeLists.txt  
>   staging/kcompletion/tests/kcomboboxtest.h  
>   staging/kcompletion/tests/kcomboboxtest.cpp  
>   staging/kcompletion/tests/kcompletionuitest.h  
>   staging/kcompletion/tests/kcompletionuitest.cpp  
>   staging/kcompletion/tests/klineedittest.h  
>   staging/kcompletion/tests/klineedittest.cpp  
>   tier2/CMakeLists.txt 51f093b 
> 
> Diff: http://git.reviewboard.kde.org/r/112758/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130919/202cba33/attachment.html>


More information about the Kde-frameworks-devel mailing list