<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112758/">http://git.reviewboard.kde.org/r/112758/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you check that it passes the "definition of done" from the wiki?</pre>
<br />
<p>- David</p>
<br />
<p>On September 16th, 2013, 3:08 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2013, 3:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not much else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(7826b07)</span></li>
<li>staging/kcompletion/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kcompletion/KCompletionConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kcompletion/autotests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kcompletion/autotests/kcombobox_unittest.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/autotests/kcompletioncoretest.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/autotests/kcompletioncoretest.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/autotests/klineedit_unittest.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/autotests/ksortablelisttest.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcombobox.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcombobox.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcompletion.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcompletion.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcompletion_p.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcompletionbase.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcompletionbox.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kcompletionbox.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/khistorycombobox.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/khistorycombobox.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/klineedit.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/klineedit.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/klineedit_p.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kpixmapprovider.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kpixmapprovider.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/ksortablelist.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kzoneallocator.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/src/kzoneallocator_p.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/kcomboboxtest.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/kcomboboxtest.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/kcompletionuitest.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/kcompletionuitest.cpp <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/klineedittest.h <span style="color: grey">()</span></li>
<li>staging/kcompletion/tests/klineedittest.cpp <span style="color: grey">()</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(51f093b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112758/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>