Review Request 112519: trim KStyle

Commit Hook null at kde.org
Wed Sep 18 15:29:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/
-----------------------------------------------------------

(Updated Sept. 18, 2013, 3:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa.


Description
-------

KStyle 2/3: Remove everything from KStyle which is not a reimplementation of the following methods: polish, unpolish, eventFilter, styleHint, pixelMetrics, standardIcons.


Note:
Probably we can remove drawKStylePrimitive (and a lot enums/structs in kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter correctly and this is material for 3/3 KStyle task :)


Diffs
-----

  staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 
  staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 

Diff: http://git.reviewboard.kde.org/r/112519/diff/


Testing
-------

It builds and tests looks OK


Thanks,

Wojciech Kapuscinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130918/bf9c8ba9/attachment.html>


More information about the Kde-frameworks-devel mailing list