Review Request 112519: trim KStyle
Commit Hook
null at kde.org
Wed Sep 18 15:29:52 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/#review40278
-----------------------------------------------------------
This review has been submitted with commit 807b861a434aef32aeb82b1e9afa9bef364206c8 by Wojciech Kapuscinski to branch frameworks.
- Commit Hook
On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112519/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 1:54 p.m.)
>
>
> Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa.
>
>
> Description
> -------
>
> KStyle 2/3: Remove everything from KStyle which is not a reimplementation of the following methods: polish, unpolish, eventFilter, styleHint, pixelMetrics, standardIcons.
>
>
> Note:
> Probably we can remove drawKStylePrimitive (and a lot enums/structs in kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter correctly and this is material for 3/3 KStyle task :)
>
>
> Diffs
> -----
>
> staging/frameworkintegration/src/kstyle/kstyle.h a3061d3
> staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41
>
> Diff: http://git.reviewboard.kde.org/r/112519/diff/
>
>
> Testing
> -------
>
> It builds and tests looks OK
>
>
> Thanks,
>
> Wojciech Kapuscinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130918/9aff5859/attachment.html>
More information about the Kde-frameworks-devel
mailing list