Review Request 112689: Drop KI18n dependencies in KCompletion

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112689/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 1:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
-------

It's not really adding much value here, so I'd say we can drop it.

I'm not sure that tr() is as well the correct replacement for i18nc(), can anybody confirm?


Diffs
-----

  staging/kcompletion/src/CMakeLists.txt dd9d99c 
  staging/kcompletion/src/kcombobox.cpp 8a73a1b 
  staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 
  staging/kcompletion/src/klineedit.cpp 76ef377 
  staging/knotifications/CMakeLists.txt 2e42ab3 

Diff: http://git.reviewboard.kde.org/r/112689/diff/


Testing
-------

builds, tests pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130916/a81b686f/attachment.html>