Review Request 112689: Drop KI18n dependencies in KCompletion
Commit Hook
null at kde.org
Mon Sep 16 13:42:26 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112689/#review40117
-----------------------------------------------------------
This review has been submitted with commit fb72740e2c9e950b91319a313469b1da8c61db14 by Aleix Pol to branch frameworks.
- Commit Hook
On Sept. 13, 2013, 11:01 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112689/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 11:01 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> It's not really adding much value here, so I'd say we can drop it.
>
> I'm not sure that tr() is as well the correct replacement for i18nc(), can anybody confirm?
>
>
> Diffs
> -----
>
> staging/kcompletion/src/CMakeLists.txt dd9d99c
> staging/kcompletion/src/kcombobox.cpp 8a73a1b
> staging/kcompletion/src/khistorycombobox.cpp 2e53bd9
> staging/kcompletion/src/klineedit.cpp 76ef377
> staging/knotifications/CMakeLists.txt 2e42ab3
>
> Diff: http://git.reviewboard.kde.org/r/112689/diff/
>
>
> Testing
> -------
>
> builds, tests pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130916/2143ab01/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list