Review Request 112545: Unify both meinproc5 binaries
Commit Hook
null at kde.org
Thu Sep 12 13:19:26 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39878
-----------------------------------------------------------
This review has been submitted with commit bcefbe5d0fe90154cec0984dae5f76f03881d5ac by Aleix Pol to branch frameworks.
- Commit Hook
On Sept. 10, 2013, 5:39 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112545/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2013, 5:39 p.m.)
>
>
> Review request for KDE Frameworks and Albert Astals Cid.
>
>
> Description
> -------
>
> Now we only have the one, which can be compiled without KArchive by ifdef'ing meinproc.cpp.
>
> I'm unsure that KArchive it's that big of a dependency, to make it optional. Opinions?
>
>
> Diffs
> -----
>
> staging/kdoctools/src/CMakeLists.txt 72bb06e
> staging/kdoctools/src/meinproc.cpp 5d476f6
> staging/kdoctools/src/meinproc_simple.cpp 334f13f
>
> Diff: http://git.reviewboard.kde.org/r/112545/diff/
>
>
> Testing
> -------
>
> Builds, both ways.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130912/8e8da5bc/attachment.html>
More information about the Kde-frameworks-devel
mailing list