Review Request 112545: Unify both meinproc5 binaries
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Sep 10 17:39:32 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
-----------------------------------------------------------
(Updated Sept. 10, 2013, 5:39 p.m.)
Review request for KDE Frameworks and Albert Astals Cid.
Changes
-------
err... of course... -.-
Description
-------
Now we only have the one, which can be compiled without KArchive by ifdef'ing meinproc.cpp.
I'm unsure that KArchive it's that big of a dependency, to make it optional. Opinions?
Diffs (updated)
-----
staging/kdoctools/src/CMakeLists.txt 72bb06e
staging/kdoctools/src/meinproc.cpp 5d476f6
staging/kdoctools/src/meinproc_simple.cpp 334f13f
Diff: http://git.reviewboard.kde.org/r/112545/diff/
Testing
-------
Builds, both ways.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/b0ec20f9/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list