Review Request 112570: Port some kde4_add_executable usages to add_executable

[David Faure]

> On Sept. 8, 2013, 9:24 a.m., David Faure wrote:
> > kinit/CMakeLists.txt, line 44
> > <http://git.reviewboard.kde.org/r/112570/diff/1/?file=187699#file187699line44>
> >
> >     This could also be moved out of the if, by using the proper arguments for ecm_mark_nongui_executable, so that it doesn't disable the mac bundle.
> 
> Aleix Pol Gonzalez wrote:
>     The macro doesn't have such an argument...

Ah I see. Reading the definition of the macro, it seems you can just do

set_target_properties(target PROPERTIES WIN32_EXECUTABLE FALSE)

to make it a console app on windows, and leave the bundle on mac.
This would be simpler I think.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/#review39569
-----------------------------------------------------------


On Sept. 9, 2013, 4:49 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112570/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 4:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> kde4_add_executable is deprecated. Port all kde4_add_executable uses to add_executable.
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html b3329d6 
>   experimental/kdeclarative/CMakeLists.txt a7bddfa 
>   interfaces/terminal/example/CMakeLists.txt e8c3f01 
>   kdesu/CMakeLists.txt 351ad85 
>   kdewidgets/CMakeLists.txt 038da6b 
>   khtml/CMakeLists.txt 124c3eb 
>   kinit/CMakeLists.txt ff7b7fd 
>   kio/misc/CMakeLists.txt e2c62d6 
>   kio/misc/kpac/CMakeLists.txt 04ffba1 
>   kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 
>   kio/tests/CMakeLists.txt 825ca3c 
>   kioslave/http/kcookiejar/CMakeLists.txt fcb620e 
>   kjsembed/examples/kjsconsole/CMakeLists.txt 2438323 
>   kjsembed/kjscmd/CMakeLists.txt f457933 
>   knotify/tests/CMakeLists.txt bc6f5e0 
>   kparts/tests/CMakeLists.txt bb8a120 
>   kpty/CMakeLists.txt 2cc2885 
>   kross/console/CMakeLists.txt 58257ca 
>   staging/kde4support/CMakeLists.txt 0445f0a 
>   staging/kde4support/src/CMakeLists.txt 6f4603d 
>   staging/kemoticons/tests/CMakeLists.txt 5e0d46e 
> 
> Diff: http://git.reviewboard.kde.org/r/112570/diff/
> 
> 
> Testing
> -------
> 
> Builds, although it doesn't change much in linux.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/a5e23ffb/attachment.html>